Devin Jeanpierre

I think that's done now. Any other files you have in mind? --- It's been a while so I didn't remember how to run addlicense and had some trouble there....

I relied on them not being included so that I could have minimal diffs. (This change broke my tests. :]) I can work around it though. I don't agree that...

Maybe, but I hope it's clear that making an opinionated decision here makes it less convenient for tools that build on top of asttokens to make different decisions. Edit: and...

@alexmojaki Thanks for the ping, will leave a comment on that issue. FWIW I am absolutely happy and fine with any decision asttokens makes. The worst it will do is...

Here's a reversed argument: normally, if you replace an expression with, say, a variable, it parses as one would expect. But here, if we replace `(x for x in y)`...

> For attribute lookup, the `Attribute` node's `last_token` will always be the name of the attribute itself. It's a single token. So I think that's a simple case, and not...

> I haven't tried it myself but you might be interested in https://github.com/Instagram/LibCST Sorry, I forgot to reply to this. I'd be open to (additionally) using LibCST, but I _really_...

(Replying out of order) > To handle empty spans, perhaps better to return (startTok, endTok), where the endTok is AFTER the last token? That would allow covering an empty token...

> I did a little thinking to clarify the goals for this. Such rules (e.g. for getting parts of Attribute or List nodes) only make sense in a particular context,...

Looks like I can't edit the issue, but feel free to assign to me.