ssande7
ssande7
@akohlmey no worries, I suspected that might be the case - I'll sort that out shortly.
Should be fixed now.
I think it's ready now for someone to take a look. I've convinced myself of correctness, so it would be good to get feedback on any code structure/user interface/etc changes...
Thanks @athomps , I think that should be possible. It wouldn't account for the bug fixes in domain, angmom, etc relating to velocity remapping, so it wouldn't give exactly the...
@athomps that makes sense - I'll see what I can do with just flags. I think at least the flag for fix deform makes sense to preserve the ability to...
@athomps I've added some flags which I think should achieve close enough to the previous behaviour - I'll leave it up to you whether it's worth the added complication (which...
Thanks @jtclemm > 1. Are the changes to remapping in the domain class equivalent to the changes in this PR https://github.com/lammps/lammps/pull/4577? Yes, it looks like they are (and I think...
One other thought - if this is all too much complexity regarding how it may interact with other use cases, an alternative might be to add a style to `fix...
> If it is more careful than erate/rescale, there might be an argument to just have it replace that style. It's more careful in the specific case of xx/yy/zz =...
> Could you recast the corrections as functions of the current box geometry so that the solution doesn't depend on the exact type of loading? I'll take a look at...