Sankar

Posting this for initial comments. I can migrate the test based on the new framework once https://github.com/valkey-io/valkey/pull/442 is merged.

@madolson @hpatro @PingXie can one of you help review this change?

> I think it's worth investing on this [redis/redis#11095](https://github.com/redis/redis/issues/11095) to avoid this issue altogether. Thanks, I wasn't aware of this linked issue. IMO these two issues can be solved independently....

I followed https://github.com/NixOS/nix/issues/7286 to install diffutils https://formulae.brew.sh/formula/diffutils Before ``` diff --version Apple diff (based on FreeBSD diff) ``` After installing diffutils using `brew install diffutils` ``` diff --version diff (GNU...

I am curious why advertising IP and switching to hostname is bad for a client. For a TLS cluster, will the client fail to establish connection if they see an...

Is viewType=2 still supported? The code tends to default to 0 if we use 2. See https://github.com/cemerick/jsdifflib/blob/master/diffview.js#L54

Yes, the behavior is the same with `pytest-rerunfailures==11.0`. ``` ======================================================================================================== test session starts ======================================================================================================== platform darwin -- Python 3.9.6, pytest-7.2.1, pluggy-0.13.1 rootdir: /Volumes/workplace/PytestSample plugins: rerunfailures-11.0, retry-1.2.1 collected 1 item test_demo.py...

> Awesome material for our next release which will be full of cluster improvements. Is it worth mentioning in release notes? > > Btw @srgsanky you need to commit with...

> B isn't processing these right? It's just immediately dropping the first three and not processing them, it only ever processes the 4th one once correct? Correct. It starts processing...

> I believe it's possible to undo a merge by git reset --hard 49a884c06 (the commit before the merge commit), then rebase to add the --signoff, then do git merge...