Sean Scanlon

Results 12 comments of Sean Scanlon

Hi Xiaoshao, Is this an issue or commentary? Do you have any specific suggestions that are actionable?

I'd like to accept this patch but there appears to be [no unit test coverage for these changes](https://travis-ci.org/sps/mustache-spring-view/builds/14064774#L696) ``` Project failed check. Total branch coverage rate of 66.6% is below...

Hi Adam, Thanks for this pull request - I haven't had a chance to review it yet, but I should in the next few days. Thanks! -sean

Are you referring to partials support at all or what this patch provides? Partials are already supported.

Hi all - If someone could provide a working example it might be possible to see what the issues are and how to correct them.

I think I see the problem. JMustacheTemplateLoader and MustacheJTemplateFactory both rely on the application context injecting the [ResourceLoader](http://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/core/io/ResourceLoader.html) via implementing [ResourceLoaderAware](http://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/context/ResourceLoaderAware.htmll). I think there might be a few @Autowired missing....

Hi @aditanase Apologies on missing this PR. For some reason I did not get a notification about this!

Hey @alugowski - this is generally good with me. Can you please resolve the findbugs issues that is causing your build to fail? ``` [INFO] Format string should use %n...

Hey @alugowski thanks for resolving those issues. It's a fair point about '\n' in this particular use case. Here is the merge conflict ``` diff @@@ -91,7 -88,14 +91,18 @@@...

Hi @alugowski - any plans to resolve the merge conflicts?