Peter Leitzen
Peter Leitzen
I am seeing the same behaviour as described by @esticle :point_up:
@adrienverge While you can use tools to determine which files are being parsed by yamllint it gets trickier if [ignoring paths](https://yamllint.readthedocs.io/en/stable/configuration.html#ignoring-paths) comes into play. In https://gitlab.com/gitlab-org/gitlab/-/merge_requests/107001 I used `strace -e...
See https://github.com/adrienverge/yamllint/pull/524
@mikevoets Thanks for the reproduction :bow: I've stumbled upon the same error when trying to [upgrade `httparty` at GitLab](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/110245) :sweat: I've fixed it [by using a `String` for `body:`](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/110245/diffs?commit_id=00036f78f136f4c6748b509d63755763bee9d290) in...
@tisdall Thank you :bow: So, let's switch to GitHub Action I guess? :sweat_smile:
@solidnerd I think we should reopen this issue since we'll need to switch at some point :sweat_smile:
:wave: @amatsuda Do you mind reviewing this optimization?
Closing this PR in favor of https://github.com/simplecov-ruby/simplecov/pull/1144. This PR only slightly improves performance compared to https://github.com/simplecov-ruby/simplecov/pull/1144: - This PR: 15s -> 8s - 1144/now main: 15s -> 9s `main` is...
I've tested `main` with the following diff: ```diff diff --git a/lib/simplecov/combine/lines_combiner.rb b/lib/simplecov/combine/lines_combiner.rb index cddffa5..97a21cc 100644 --- a/lib/simplecov/combine/lines_combiner.rb +++ b/lib/simplecov/combine/lines_combiner.rb @@ -32,12 +32,12 @@ module SimpleCov # # @return [Integer ||...
Note that it works for other Rails cops like `Rails/NegateInclude`. Consider this file `lib/1.rb`: ```ruby # frozen_string_literal: true x = ![].include?(x) puts x exit 1 ``` Without department exclude I...