Neil Williams comments

Results 27 comments of


                                            Neil Williams

fix cheater check

:fish:

Slack: Invite users to channel when pinging them

Sadly not possible since harold is a Bot user https://api.slack.com/methods/conversations.invite

Slack: Invite users to channel when pinging them

Maybe send a PM instead?

Allow indirection in secret names w/ secret-fetcher

Credit to @eaceaser for the suggestion/request.

Track time taken getting connections from connection pools

Perhaps a binary log on the child span?

Make it easier to deal with message queues in testing

Lazily opening the message queue on first use could dodge the pain when events aren't actually used, but if they are we're still in the same world of hurt. It's...

Update rediscluster client to v2.1.3

Thanks for the report! That sounds like a nasty issue. What would you like to see changed here? Baseplate.py only sets a minimum version (https://github.com/reddit/baseplate.py/blob/develop/setup.py#L15, 2.1.2) which we can happily...

Update rediscluster client to v2.1.3

Cool! Are you interested in submitting a patch for that?

Figure out what's wrong with config.Optional(config.DictOf)

Your tests seem to be checking `service_whitelist` while the config involved is `bar`. `Optional` seems to work fine for the basic use case: https://github.com/reddit/baseplate.py/blob/master/tests/unit/config_tests.py#L233-L245

Figure out what's wrong with config.Optional(config.DictOf)

Ah sorry, `service_whitelist` in the original example was me leaving bits of the original code behind.