Florian Spier

Results 33 comments of Florian Spier

Probably a super naive solution, still I want to share it: Try catch around the nextFn... ``` export function tapResponse( nextFn: (next: T) => void, errorFn: (error: E) => void,...

Fixed it with try catch in MiniRx :) https://github.com/spierala/mini-rx-store/pull/117/files

I have a related question: Is the generic type for `effect` always required? Effects without parameters require then the generic type `void`? I made a small example here: https://stackblitz.com/edit/angular-ivy-jsnxmn?file=src%2Fapp%2Fstate.service.ts The...

@LayZeeDK I think the `trigger$/source$` is the most natural way. Also, that approach is used in the docs already. standalone pipe: To me the standalone pipe always looks strange. I...

> That's an interesting point. But how is it different than having `trigger$.pipe(singleOperation())`? `trigger$` isn't needed at all for most effects yet `.pipe` is also needed even for a single...

Hi, I created this little isDst fn which is based on the Luxon implementation. Maybe useful as a workaround or it could be used for a future PR. ```typescript function...

Yeah, very sad to see ngx sortablejs not being maintained. There are even community contributions to make it work again with ng12 and ng13. Why not merge that MRs (#246...

@Anikethana I believe that we should add "compilationMode": "partial" in the libs prod tsconfig https://angular.io/guide/creating-libraries#ensuring-library-version-compatibility

Hi @M5150, There was recently a similar issue regarding the undefined window object: https://github.com/spierala/mini-rx-store/issues/121 I found it strange that the ReduxExtension can throw an error even if it is not...

Do you have issues only with the DevTools? What if you remove the extension? Do you see a specific error? Thinking about a fix like this one: https://github.com/jonoward/ng2-redux/commit/5ecc43e403b2a23c2529ffef23dfcb561d8b8061