spernsteiner
spernsteiner
I checked most of the larger graphs in the snapshot diff and they all look good to me.
Have you tested the new `AddrOfLocal` handling on code with loops or other interesting control flow? The current strategy involves special handling for the first initialization of a variable, and...
Snapshot changes look good to me
One downside I see to this approach is that in some cases it forces the node names in the assertion to be out of order compared to the graph, which...
This whole PR is superseded by the approach in #668, right?
I think I've addressed all the previous comments. I used the "resolve conversation" button liberally to help keep track of which threads I'd already handled - feel free to unresolve...
I've addressed the remaining comments. I added doc links only in the comments that were added or modified in this PR, to avoid polluting the diff with unrelated changes -...
Option 1 seems brittle. I wouldn't be surprised if some systems set arbitrary limits on how much data can be written in a single `write` call. Linux has such a...
I don't think there's a standard API for that.
The analysis `augment_with_info` uses for read/write/offset does `O(N^3)` work on each graph (where `N` is the number of nodes in the graph), which will be very slow for reasonably sized...