Geoffrey MUSELLI

Results 40 comments of Geoffrey MUSELLI

@crenshaw-dev I will try this

@crenshaw-dev thanks a lot for your suggestion. Here are the outcome of a discussion with a colleague: `path` object contains: - `path`: the full path (previous `path` variable) - `segments`:...

@crenshaw-dev really good idea. Let me try it

If we replace only complex values (ie: `some.value`) we will miss all variables with a simple word. Example: ```yaml apiVersion: argoproj.io/v1alpha1 kind: ApplicationSet metadata: name: guestbook spec: generators: - list:...

Last regexp and corner cases: https://regex101.com/r/ghzt0b/4 `{{ hello.hello-world }}` Should match and Must be transformed into `{{ index .hello "hello-world" }}`. We can also do the following logic ```bash if...

@crenshaw-dev Here is what I can propose with legacy handling and transformation (with unit tests) https://github.com/speedfl/argo-cd/commit/29c42bde998cae26e4a26d5e279dc9ee346f8790 If you are ok I can update the documentation + add some integration tests

@crenshaw-dev I did all the adaptation. - I ensured backward compatibility by putting back all unit tests & e2e tests with fasttemplate. There is a bit of test duplication but...

@crenshaw-dev yes I keep the logic for fast template: https://github.com/argoproj/argo-cd/blob/master/applicationset/utils/utils.go#L76-L87 I just removed the `allowUnresolved` as looking at the code non are using `allowUnresolved=false`. In addition I factorized the code...

@crenshaw-dev you are right. It is blocking. Well seen. I added a unit test and working on the fix :)

@crenshaw-dev I was able to fix this issue. I added a beautiful unit test in utils_test.go :D ```golang { name: "Index", fieldVal: `{{ index .admin "admin-ca" }}, \\ "Hello world",...