José Padarian comments

Results 25 comments of


                                            José Padarian

Fix crate build on docs.rs

Do we still need ``` [package.metadata.docs.rs] rustc-args = ["--cfg", "docsrs"] ``` in `Cargo.toml`?

Work around docs.rs problem with cargo (ref #240)

@rmanoka This temporary fix to the doc.rs problem works fine locally (it generates the docs) but it's failing CI for ubuntu-lts. - GDAL version in LTS is 3.0 - Clippy...

Work around docs.rs problem with cargo (ref #240)

We still have the problem.

Work around docs.rs problem with cargo (ref #240)

No problem. It is a workaround, so I understand that you need to hear from the other maintainers. If it helps, I could add a panic if the feature is...

Work around docs.rs problem with cargo (ref #240)

I added the following message: ``` The `docsrs` feature should not be enabled. If you are using the `--all-features` flag, try replacing it with `--features bindgen,array`. See https://github.com/georust/gdal/pull/241 for more...

Work around docs.rs problem with cargo (ref #240)

How does that interact with markers such as `#[cfg(all(major_ge_3, minor_ge_1))]`? Would those docs be compiled if the version is `2.6`?

Work around docs.rs problem with cargo (ref #240)

That looks different from what @michaelkirk was saying, right @rmanoka? Anyway, it works which is the important thing! If I understand correctly, you are generating the code dynamically, so the...

docs.rs failing to compile dependent crate

I will give that a try tomorrow. Is there a way of checking if that works locally? I guess I can use their docker container... Just to confirm... not `rustc-args...

docs.rs failing to compile dependent crate

Apparently, the guys from docs.rs have reported a bug in cargo, which is still blocked on https://github.com/rust-lang/cargo/issues/10206

docs.rs failing to compile dependent crate

I tried locally and it still fails...