spacesailor24

Results 24 issues of spacesailor24

Before this PR, `web3Eth.signTransaction` was returning whatever the user passed as the `transaction` parameter for `respnose.tx` when the RPC client was returning only the RLP encoded transaction as the RPC...

4.x

- We should implement a disclaimer as mentioned [here](https://github.com/ChainSafe/web3.js/pull/5251#discussion_r932016753) that notifies the user that methods exported from `rpc_method_wrappers.ts` are expected to not be used by most users - We should...

4.x

There was a report in the ChainSafe discord that the symlinks don't work on Windows and therefore the `4.x` branch cannot be properly setup in a Windows env

Investigate
4.x

[Lerna](https://github.com/lerna/lerna) seems to no longer be maintained, so for `4.x` we could probably rely solely on Yarn Workspaces

4.x

**Note** There are a huge amount of files changed, but most of these files are tests where the only change was an import change to `import { ethRpcMethods } from...

4.x

Example implementation for #5091 ### Points of Discussion - I believe the `Web3APISpec` on [this](https://github.com/ChainSafe/web3.js/blob/d0d388b6f26b739d787653285f1ba8a88eb4fcfe/packages/web3-plugin-example/src/index.ts#L44) line should be `ChainlinkPluginAPI`, but when making the change the following error appears for [this](https://github.com/ChainSafe/web3.js/blob/d0d388b6f26b739d787653285f1ba8a88eb4fcfe/packages/web3-plugin-example/src/index.ts#L55)...

4.x

--- ## `web3-core` ### Changed - `privateKey` argument for `TransactionBuilder` type was changed from `HexString | Buffer` to `{ privateKey: HexString | Buffer; privateKeyToAddress: privateKeyToAddress }` (#5458) - Return type...

4.x

Originally brought up [here](https://github.com/ChainSafe/web3.js/pull/5312#issue-1328068259) in PR #5312, there are instances where our library will return `gasLimit` and other times when it returns `gas` within transaction objects. This issue tracks the...

4.x

`--forceExit` flag should be removed from the `test:integration` npm script in `web3-eth` package, but can't because there seems to be hanging promises in: - [rpc.test.ts](https://github.com/ChainSafe/web3.js/blob/4.x/packages/web3-eth/test/integration/rpc.test.ts) - [subscription_logs.test.ts](https://github.com/ChainSafe/web3.js/blob/4.x/packages/web3-eth/test/integration/subscription_logs.test.ts)

Investigate
4.x