J Paul Lescouzères
J Paul Lescouzères
Thx for this quick answer! I must be missing something but, why should I use memoization? Aren't both patterns eqs?
Hmmm... I'm not sure to perfectly understand why, but I'll be looking for some infos within the linked discussion :+1: Thx a lot @dai-shi !
Ok thx a lot for all these informations, let's read (and learn) then :slightly_smiling_face:
As discussed, the `Slider` component implementation of hover/pressed states has been treated in implementation ticket: https://github.com/adevinta/spark/issues/961 cc @JeremiasUX @turolopezsanabria
@michael-zimmermann Why assigning yourself a web ticket? I guess it was a mistake? 🙂
@jcatdom @chuxui @JeremiasUX Do you want to review the changes? - https://spark-ui-uhip-gtg34o6ci-sparkteams-projects.vercel.app/?path=/docs/components-checkbox--docs#intent - https://spark-ui-uhip-gtg34o6ci-sparkteams-projects.vercel.app/?path=/docs/components-radiogroup--docs#intent
@elisa-hery Sorry for issue being closed after merging first of two PRs... I reopen it, here is the last one for testing purpose: https://github.com/adevinta/spark/pull/1618
> 1. using keyboard navigation we can have a rate of 0/5 and it should not be possible Why? We can't do it with mouse or touch events, but there...
Expected changes on keyboard interaction are included there: https://github.com/adevinta/spark/pull/1642
Updated environment for testing/review purpose: https://spark-5uda4jwjp-spark-team.vercel.app/?path=/docs/getting-started--docs