sovdee
sovdee
You can just change it entirely since 2.10 will be 1.19+
> > what's the status of the junit tests? > > i think the EffEntityVisibility test is fine, but not really sure how to improve the one for CondCanSee. maybe...
@Efnilite conflicts :(
> > still needs tests > > See #5312 This PR should have its own regression tests so it's not dependent on the other pr for merging
Inactive
I'm not sure how useful this will be going forward, as we intend to mostly sunset aliases for 2.10. That said, I don't know what the end result there looks...
> > Looks good, the only thing missing is some tests! This would need JUnit tests, so if you're not comfortable with adding those, please let me know and I...
Your expressions aren't gated behind class exists checks
Barter drops and barter input are registered without checking if the event class exists. I'm not sure if that's the root cause of the test exception, I didn't look closely.
Can you recreate this without addons?