Liang

Results 19 comments of Liang

> LGTM. > Please update the PR description. > And let's add tests and docs. tests added

> …efore hummock manager operations > > I hereby agree to the terms of the [Singularity Data, Inc. Contributor License Agreement](https://gist.github.com/skyzh/0663682a70b0edde7ae991492f2314cb#file-s9y_cla). > > ## What's changed and what's your intention?...

> LGTM. Before merge, I suggest we > > * replace https://github.com/risingwavelabs/risingwave/blob/4998ba94da6f85f1568fa36a399e21a5797b05b9/src/frontend/src/handler/create_mv.rs#L122 > * provide benchmark result to compare performance of main's 2 static group with this PR's more dedicated...

> LGTM. Before merge, I suggest we > > * replace https://github.com/risingwavelabs/risingwave/blob/4998ba94da6f85f1568fa36a399e21a5797b05b9/src/frontend/src/handler/create_mv.rs#L122 > * provide benchmark result to compare performance of main's 2 static group with this PR's more dedicated...

> LGTM. Before merge, I suggest we > > * replace https://github.com/risingwavelabs/risingwave/blob/4998ba94da6f85f1568fa36a399e21a5797b05b9/src/frontend/src/handler/create_mv.rs#L122 > * provide benchmark result to compare performance of main's 2 static group with this PR's more dedicated...

bench sql: ``` create source person (id INTEGER, name VARCHAR, "email_address" VARCHAR, "credit_card" VARCHAR, city VARCHAR, state VARCHAR, "date_time" TIMESTAMP) with ( connector = 'nexmark', nexmark.table.type = 'Person', nexmark.split.num =...

> LGTM. Before merge, I suggest we > > * replace https://github.com/risingwavelabs/risingwave/blob/4998ba94da6f85f1568fa36a399e21a5797b05b9/src/frontend/src/handler/create_mv.rs#L122 > * provide benchmark result to compare performance of main's 2 static group with this PR's more dedicated...

> LGTM. Before merge, I suggest we > > * replace https://github.com/risingwavelabs/risingwave/blob/4998ba94da6f85f1568fa36a399e21a5797b05b9/src/frontend/src/handler/create_mv.rs#L122 > * provide benchmark result to compare performance of main's 2 static group with this PR's more dedicated...

@zwang28 Could we finish it? I plan to issue an optimization scheme for compaction groups today.

> * compaction group in the first version of compaction deterministic test tool, if it requires lots work to adapt to arbitrar @Gun9niR @wenym1