Sukkyu Chung
Sukkyu Chung
Closes https://github.com/adobe/react-spectrum/issues/6197 I could've placed the logic in [disablePendingProps](https://github.com/adobe/react-spectrum/blob/main/packages/%40react-spectrum/button/src/Button.tsx#L36-L50), but thought it might be confusing for the user to see [the warning message](https://github.com/adobe/react-spectrum/blob/main/packages/%40react-aria/button/src/useButton.ts#L115) every time they click on the button...
Closes https://github.com/adobe/react-spectrum/issues/6383 ## ✅ Pull Request Checklist: - [x] Included link to corresponding [React Spectrum GitHub Issue](https://github.com/adobe/react-spectrum/issues). - [x] Added/updated unit tests and storybook for this change (for new code...
### Provide a general summary of the issue here Based on the code below and https://www.w3.org/WAI/ARIA/apg/patterns/checkbox/#keyboardinteraction, it should be the case that 'Enter' key shouldn't invoke Checkbox toggling: https://github.com/adobe/react-spectrum/blob/b294de874c16fad64bc4b930ccee1c9ffeb1c20f/packages/%40react-aria/interactions/src/usePress.ts#L904-L909 But...
Closes https://github.com/adobe/react-spectrum/issues/6327 It just occurred to me that it might also be nice to update the type for `selectedKey` from `Key` to `Key | null`. Should I include that as...
Hopefully closes #17 Well I was not positive that I would be able to put together a PR for this feature, but thanks to @cpojer's comments in #17, here is...
This PR is my attempt at #35. The implementation kinda got bloated to cover the case where optional objective amount fails due to one of the target objectives is no...
Closes https://github.com/adobe/react-spectrum/issues/5940 I'm not sure this is the direction @snowystinger wanted in https://github.com/adobe/react-spectrum/issues/5940#issuecomment-1963071411, but I found it rather difficult to implement the fix inside the `usePress()` hook. I ended up...
Hello, this PR is not related to any existing issue, but I was trying to use the example code presented here: [Contact List](https://react-spectrum.adobe.com/react-aria/examples/contact-list.html) and noticed that the variables `favorites` and...