Manish Kumar

icon company Appsmith icon location India icon location Dear successors of Ada Lovelace! If you have managed to stumble upon this bio then here's a fun fact for you! The moon is upside down in southern hemisphere.

Results 26 comments of Manish Kumar

feat: Making the error messages in amazon s3 plugin informative

/ok-to-test sha=d030460

feat: Informative error messages on cyclic dependency for queries on page load

/ok-to-test sha=15cb6bd

feat: Informative error messages on cyclic dependency for queries on page load

/ok-to-test sha=7d9733f

chore: rename_triggerUtils

@appsmithguru You need to change the title of the PR to be in a format `fix/feat/chore: `. i.e `fix: trigger util refactor`. fix: if you are providing a fix for...

chore: rename_triggerUtils

@appsmithguru The fix link should include the url for issue for which this PR has been raised.

chore: rename_triggerUtils

The changes looks good, however since this utility file is helping in building a call for restapi, can we rather think about refactoring the name to `RestAPICallBuilderUtils`.

chore: rename_triggerUtils

Since, the changes are only class name refactoring, the current test cases are adequate in my opinion. @btsgh @prapullac

chore: decomposing action execution flow methods into smaller methods

/ok-to-test sha=595f028

chore: decomposing action execution flow methods into smaller methods

/ok-to-test sha=8481a84

[Bug]: Simple regex strings with variable replacement fail in MongoDB queries

@Nikhil-Nandagopal The logic that handles this flow is associated with smart substitution which is separate from what datatype handling project worked with. As a current workaround we can use this...