son-phamngoc

Results 23 comments of son-phamngoc

Hello @mkgrgis, thank you for your effort. In my understanding, if we want to enable PostGIS to be able to use its data types, we need to CREATE EXTENSION PostGIS....

@mkgrgis Thanks for your answering. > If you want try this PR code with PostGIS in normal style, please comment creating of domains with special names, use automatically created internal...

> What about SpatiaLite versions on your system, @son-phamngoc ? How did you get the files? @mkgrgis I used libspatialite-devel version 5.0.0-1. I installed it by command `dnf install libspatialite-devel`....

@mkgrgis Did you try the same as me: CREATE EXTENSION PostGIS and comment out all domains with special names? I think I found the problem. My environment uses PostGIS 3....

> This FDW works with PostGIS 2+ and confirmed with SpatiaLite 5.1. @mkgrgis Could you tell me why this PR only works with PostGIS 2+? Is there any reason that...

> Why I thinks we shouldn't test PostGIS functions? Because after my PR I have normal bytea data for PostGIS. Maybe I have forgotten some SQL conversion marker or context?...

@mkgrgis Thanks for your understanding. > Yes. Now I have understood this is not enough. We should also test PostGIS output for the values. > Yes. On my real (not...

> Have you trying to get available PostGIS on testing PostgreSQL installation? Please add the following code to Makefile of sqlite_fdw. After that, you can execute `make check` with PostGIS....

@mkgrgis Thank you for your support. My work is so busy, so I could not check this immediately. Please wait for a few days. Sorry about that.

@mkgrgis Sorry for late response. I would like to share some information. For this PR, it has a new feature which requires additional libraries to be installed. Therefore, we would...