Ivan Babak

Results 79 comments of Ivan Babak

> an approach could be to check if the debug component is set on the a-scene element. Querying the browser DOM is slow compared to querying a JS variable. Especially...

But of course both approached should be benchmarked to find the most performant. Using the de-facto standard debug module lets the users to remove the debug calls in production builds....

https://github.com/mubaris/curiosity/issues/75 Confusing project name when repository author/organization isn't shown

According to the profiler: The lag is happening within a `spawn` via `Task` (it's quite surprising that `pigments` spawns a separate process). Below is the code that happens to be...

This part of the Node.js `ChildProcess` seems to run the slowest when called from `scanBufferForColors` (this is the native code process spawn operation): ```js var err = this._handle.spawn(options); ```

The Bower manifest file should be `bower.json`, not `bower.js`

We may assume these failing cases as marginal and just really report them as errors. There is no need in the real code to pre-create effects and then yield them...

@pke Sorry, please reopen because I can't, there's no button. See my comment here why your solution isn't right: https://github.com/pke/eslint-plugin-redux-saga/commit/7c811c27607f8284caf758965a270cb78c7f839a#commitcomment-18338350

I suggest the plugin should ensure that the `yield` operator operates on the effect creator return value, the effect creator being imported from the `redux-saga` module in the files where...

@pke PR #4 is good, left some comments there. Would this new rule replace the original `yield-effects` one? Looks like they are the same to me.