Brett Sun

Results 199 comments of Brett Sun

I assume rollup should be noticing `require('./ComponentA')` and replacing it with a proper link to the bundled module, but instead it's leaving it alone. If I replace `require('./ComponentA')` with `babelPluginFlowReactPropTypes_proptype_ComponentAType$1`,...

@duaraghav8 Slightly different; in the case of the `ACL`, I'd like to remove the offenders ([`initialize()`](https://github.com/aragon/aragonOS/blob/dev/contracts/acl/ACL.sol#L61) and [`grantPermissionP()`](https://github.com/aragon/aragonOS/blob/dev/contracts/acl/ACL.sol#L104)) entirely from the rule rather than the functions that are in the...

Not entirely sure how solium handles option setting via comments in files (can it?), but it'd be great if this were supported as well on a per-file basis that way.

YAML could be used instead of JSON as a more friendly serialization format in files, but on some level I'm not sure this will be _that_ useful to most people...

> It is a good practice to enforce visibility on constants I would agree with this, and in general explicitly stating visibility is a good thing (maybe there should be...

@pwmckenna It'd also be nice to include sass/scss support, since those are fairly commonly used too. I don't mind making another PR based on this one, but it seems like...

@TimDaub Combining the two sounds good. Making `rightsOf` mandatory when the `RightsType` is `Copyright` and optional when the `RightsType` is a `SourcedRight` seems cleanest. `source` would also not apply for...

@alexanderattar Yes, they would have to be merged with some notion of "optional" and "required" depending on the type.

For disputes themselves, there is some implicit, inherent interest from the plaintiff in invoking this action so potentially, it is something they would want to pay for and call anyway,...