Ben Lovell

Results 12 comments of Ben Lovell

Here's a sandbox that recreates the problem: https://codesandbox.io/s/vertical-list-c5dol?fontsize=14&hidenavigation=1&theme=dark Scroll to the bottom of the outside frame, but make sure the draggable frame is scrolled all the way to the top....

Not sure how/if compiling Java sources in a separate profile effects things? Can you expand? I wouldn't mind trying it out. The main requirement is that I need to emit...

This is blocking me from updating — any ideas how to workaround this in the meantime?

After a full night's sleep I solved it! :) I was doing ```bash sudo rm -r ~/.nix-channels nix-channel --update ``` which would error out when I did `darwin-rebuild switch --flake...

For reference, this is how it was solved in jshell: https://github.com/openjdk/jdk/pull/10166 Looks like they override the jdk internal(!) [MethodVisitor](https://asm.ow2.io/javadoc/org/objectweb/asm/MethodVisitor.html#visitJumpInsn(int,org.objectweb.asm.Label)) to [add a check](https://github.com/openjdk/jdk/commit/ffc249ae2120752a9c0e9de18167b0c16f2de410#diff-c36ffff66439858a380f5d665260d18eef6d57d52157621b2bb731ac2ee1581aR84-R88) to a [new static method](https://github.com/openjdk/jdk/commit/ffc249ae2120752a9c0e9de18167b0c16f2de410#diff-c36ffff66439858a380f5d665260d18eef6d57d52157621b2bb731ac2ee1581aR99) on every...

@bbatsov yeah, `.interrupt` only works if the user code respects it, which is why jshell is injecting in a boolean check in the jvm bytecode for every looping instruction —...

Would you say the new resizable columns alleviates this somewhat? Obviously it's not fully responsive, but I guess the majority use case is when you have it open in two...

I've incorporated some of the feedback, and left some comments on the others. Whenever you have some time I'd appreciate another look!

I've updated again with the new suggestions. Obviously as a newcomer it's not my position to dictate how you run this project, but I would suggest that a lot of...

Thanks for the suggestion, and thanks for the reviews. I don't really think it's my place as a newcomer to push drastic changes to the way you do things, just...