Sara Reynolds

Results 46 comments of Sara Reynolds

Great! Also feel free to take a look at some of the runbooks and let me know if you think they'd be useful for the general audience.

hey @penandlim ! That's the correct address for the ERC20 version. We have not deployed the 721 or 1155 version as those are still in development and in need of...

- rename log groups, the current names are not super helpful in helping you find certain codepaths - remove any stale log groups that are being unused

[script](https://github.com/snreynolds/pinatascript/blob/master/unpin.ts) ready whenever we want to delete old data. longer term going to have @zhongeric write a cron job for this in routing-api.

HI @mds1 - No this was never resolved. Put up a draft [here](https://github.com/Uniswap/v4-core/actions/runs/5784698824/job/15675902138) so you can see the replication. Its failing on the fuzz results. I read though that snapshots...

> as i understand, not only should snapshots already have a fixed seed, but setting a fixed seed for all tests would mean that you lose the benefit of additional...

@0xalpharush I moved to using the library explicitly and I'm still not seeing updates in `forge coverage`. See commits here https://github.com/Uniswap/relayer/pull/57

Hey @Joeysantoro love the flag here for ERC-4626. We designed permit2 to support other token types (ERC721/ERC1155) as well but each token standard would have their own canonical permit2. So...

hey @Joeysantoro looping back in here. I think we'd be down to support ERC4626 in this repo but in a different contract similar to how we are doing ERC721 and...

Sweet, this looks really great - definitely expecting some decrease in gas. +1 to @marktoda comment above though about running the gas tests against each change