Stefan Novaković comments

Results 8 comments of


                                            Stefan Novaković

Fix sorting of array with multiple types

There is still some know issues with this update as e.g ``` sort([1, 3, 2, '1a', 'a', '2', '5', 6]).asc() // === [1,2,"2",3,"1a","5",6,"a"] ``` But currently trying to find balance...

fix: arrays with multiple types

@mesqueeb Thanks for bringing this issue and for the PR! One hesitation I have with merging this is that it has big impact on performance even on arrays that don't...

fix: arrays with multiple types

@mesqueeb I open PR (influenced with this one) with performance in mind https://github.com/snovakovic/fast-sort/pull/64 I would appreciate if you have time to peek at it. There is still some know issues...

Support seal and preventExtensions.

I will leave it here for any future reader. There is [`js-flock library`](https://github.com/snovakovic/js-flock) that have deepFreeze, deepSeal and deepPreventExtensions modules. Library is also actively maintained and deepFreeze have other improvements...

cannot sort on multiple types in an array

@mesqueeb things should work as expected from v3.4.0

fix: arrays with multiple types

Closing this PR due to performance implication mentioned in previous comment https://github.com/snovakovic/fast-sort/pull/61#issuecomment-1225906797

Fix sorting of array with multiple types

@mesqueeb on second look manage to solve above issue without performance penalties so there is no need for separate function

Cannot find name radonly TS error

Closing as it's only issue on TS prior to version 3.4. Recommended fix for it is to upgrade TS to 3.4+ as @VividLemon has mentioned in above comment.