Zach Stein

Any update on this? PHPCS is an important part of our workflow.

Hey Facebook team We're still maintaining this patch in our repository because we want into that SQL query issue I mentioned (In my issue report) any plans to merge this?

Thanks! Looks like you guys merged a variant of this PR. I've closed this PR and updated my fork.

Fourth logic error I noticed... ` $categoryNames = []; foreach ($categories as $category) { $categoryNames[] = $category->getName(); } ` You guys overwrite categoryNames for each item in the loop, so...

Also FYI - This is what that SQL error log looks like. #0 /home/jetrails/XXXX/html/vendor/magento/framework/DB/Statement/Pdo/Mysql.php(89): Magento\Framework\DB\Statement\Pdo\Mysql->tryExecute(Object(Closure)) #1 /home/jetrails/XXXX/html/vendor/magento/zend-db/library/Zend/Db/Statement.php(313): Magento\Framework\DB\Statement\Pdo\Mysql->_execute(Array) #2 /home/jetrails/XXXX/html/vendor/magento/zend-db/library/Zend/Db/Adapter/Abstract.php(480): Zend_Db_Statement->execute(Array) #3 /home/jetrails/XXXX/html/vendor/magento/zend-db/library/Zend/Db/Adapter/Pdo/Abstract.php(242): Zend_Db_Adapter_Abstract->query('SELECT `e`.* FR...', Array) #4 /home/jetrails/XXXX/html/vendor/magento/framework/DB/Adapter/Pdo/Mysql.php(564): Zend_Db_Adapter_Pdo_Abstract->query('SELECT...

Hey Taxjar team Any plans to merge this PR? Your extension may not work correctly with supported versions of Magento without this update. We're currently relying on a patch I...