Sailesh Mukil

Results 27 comments of Sailesh Mukil

Reviewing this now. Will get back shortly with comments.

@axelfauvel I've submitted a review above.

@ivancoppa @lhucinequr I will investigate this and get back.

@ivancoppa I was unable to track down any leaks. I'll get back to it in a bit and try to have an update soon.

@kallaballa The msg struct comes as part of the fork from twemproxy. The best way to analyze the struct is to look at it under GDB to see how it's...

@kallaballa 'keys' basically holds the array of all keys mentioned in the query. Eg: The Redis query 'smembers myset', would have mean that the 'keys' array has one element called...

Hi @kallaballa . It may be the case that some debug/higher verbosity statements may have some implicit behavior changing effects which are definitely bugs, and if you find them, including...

@kallaballa I can have a look at it, but my review might be slow since I don't have too much context on Kyoto Tycoon yet. I would suggest that if...

@emiteze Sorry for the slow response. Let me have a look at this and get back to you.

@emiteze The node03.yml 'rack:' field points to 'dc1-rack1'. You'd need to change it to 'dc1-rack2', right? Right now, it thinks all 3 nodes are part of the same rack and...