Stanislav Molchanovskiy

Results 19 comments of Stanislav Molchanovskiy

This class is really helper for testing and replacing implementations. But you are absolutely right, without an interface it makes no sense. For some reason, I forgot to add it,...

@force-net hi! 4 years have passed, I think it's time to merge pr, if everything is ok =)

Hi @parthvnp ! It will be very cool if you do it =) Assigned the issue to you

Having excluded the forked parts of the code (they have already been tested), we found out the real percentage of test coverage - 74%. Just a little bit left! :)

It seems that there are enough integration tests for the client, but there are none for the factory. We need to think about how to implement them. Unit tests are...

@kolatcole hi! No, you can do it :)

Sorry for the late reply I don't understand your suggestion. I'v used OPA like a proxy for backend API and I don't imagine how it can be applied to nclient....

Hi @JorgChrist ! Sure :) I think you'll need [ClientInterceptor.cs](https://github.com/nclient/NClient/blob/main/src/NClient/NClient.Standalone/ClientProxy/Generation/Interceptors/ClientInterceptor.cs) class. Write if you have any questions, I will be glad to help

Hello, @JorgChrist! Can I help you with something? Or did you not want to take this issue?

Hi, @JorgChrist! The project has really become quite large, it seems I need to work on a guide for contributors to make it clearer. Unfortunately, I can't do it right...