Dominic Smith comments

Results 6 comments of


                                            Dominic Smith

Future roadmap?

:+1:

Feature request - list open pull requests

Has anyone looked at using the graphql api for this? Something like this could could work... ``` query { organization(login: "some-org") { repositories(first:100) { nodes { name openPullRequests: pullRequests(states:OPEN) {...

Can't use machine credentials.

So that works for aws config files if you're using profiles , but it doesn't for ec2 roles. ec2 role credentials are obtained by the sdk over a link-local address....

SetLogger takes an internal type, which is not accessible from external code

> Is the logger working at all? I passed my implementation but still dont see anything being logged. +1 here, I'm getting 3 errors when I restart redis, only one...

SetLogger takes an internal type, which is not accessible from external code

Never mind, I had an orphan process still running :(

fmt: preserve spacing in templates to allow for organizing code

> I think the goal of a formatter is to be consistent, but by retaining whitespace, you end up with oddities. I think following the same rules as gofmt would...