Andrew Smith

Results 33 comments of Andrew Smith

Any update on this? I was quite excited about the prospects of DataStore, it's API, and how it works, however without this ability I cannot use it at all within...

@e-schultz @SethDavenport @danielfigueiredo @rpdasilva thoughts and comments appreciated

@e-schultz Yes, this is not a breaking change and can be put into 6.x as it is still compatible with the existing way of configuring the store. The only thing...

I'm up for removing the NgModule related parts. I'll look into refactoring the subStore things into the feature as described, but my main concern was that I didn't actually want...

@SethDavenport Had a chance to update the PR on top of your recent changes and also removing the NgModule bits. I think the `configureSubStore` logic doesn't quite match up to...

I believe @SethDavenport wanted to take a look at refactoring this to include some of the subStore code last we spoke. Documentation and examples still outstanding. Haven’t had much OSS...

My personal approach would be to ensure that you are unit testing the selector function itself only. So in your case, there should be an isolated suite of tests for...

So while I’m glad to have a repository of community resources, I’m not sure if the main read me page is the right place for it. Maybe we could put...

Just waiting for the suggested change of utilizing a `Community Resources` markdown file instead

Unfortunately ConnectArray in its current state does need some love. I would be happy to help if someone can create a reproduction on StackBlitz or similar.