Miroslav Smiljanic
Miroslav Smiljanic
The build on my machine fails because of baseline plugin ``` $ mvn clean install -DskipTests .... [ERROR] org.apache.jackrabbit.oak.segment.azure.util: Version increase required; detected 1.0.0, suggested 2.0.0 [INFO] BUILD FAILURE [INFO]...
@ierandra, I would prefer if you let me resolve the PR comments that I have started. This post captures well the resoninig I have in mind https://www.danclarke.com/resolving-pr-comments
Thanks @ierandra I am having a look. In the meantime, I started the build, and it failed. A bunch of test are failing on my local machine as well when...
@ierandra the build first failed in jenkins https://github.com/apache/jackrabbit-oak/actions/runs/12028412044/job/34038518960?pr=1748
https://github.com/apache/jackrabbit-oak/actions/runs/12028412044/job/34597299155?pr=1748 ``` Error: deactivate(org.apache.jackrabbit.oak.segment.azure.AzureSegmentStoreServiceTest) Time elapsed: 0.006 s
I have changed the test to cause ```TimeoutException``` instead of mocking it.
> I think the fix should also be added to V8 implementation. @ierandra will address it in a separate PR
I decided not to update reactor-core, as the Azure documentation advises against using a version with a different major or minor version than the one specified in the Azure SDK...
> > I think the fix should also be added to V8 implementation. > > @ierandra will address it in a separate PR The AzureRepositoryLockV8 is already correctly handling client-side...
@ierandra, looking at the code, all exceptions that happen in AzureRepositoryLockV8#refreshLease should be logged. Do you perhaps have the stacktrace? I suggest we move the discussion for v8 to the...