Miral Gadani
Miral Gadani
@tbg Yep. Marking as draft for now.
This is rebased on top of https://github.com/cockroachdb/cockroach/pull/88556 which introduces structured errors. Detecting the SSH flake via substring still works and keeps this PR simple. This might be a good place...
> A chance of a false positive (via substring) is probably very low, but structured errors should make it cleaner and pave the way for more cases. I am thinking...
>As general food for thought for everyone: IMO, errors like cluster creation and SSH problems are better reported in a more concise way other than a GitHub issue. We just...
The second commit switches to using errors/marker api to mark an SSH flake where it is detected in roachprod. This allows us to look for a marker exception and act...
Test name will be prepended to issue body in the case of cluster creation AND ssh flakes. Other conversations resolved. Will merge after TC builds are green.
bors r=tbg
bors retry
This latest one seems to be introduced by https://github.com/cockroachdb/cockroach/pull/108427 cc: @pavelkalinnikov
Thanks @renatolabs . > Improve the test timed out message to properly report time spent in the test. This could be done by reusing the default timeout [1] or (even...