smartcontracts

Add a noCompile option to etherscan verification

7

We use `hardhat-etherscan` programmatically *during* our deployment process to automatically verify contracts as we go. We do this because we take various steps throughout the deployment where we need additional...

Error: Couldn't find ethers-v5 (yarn workspaces)

6

I'm getting the following error on the latest version of typechain: ``` Error: Couldn't find ethers-v5. Tried loading: @typechain/ethers-v5, typechain-target-ethers-v5, /home/k/Projects/work/optimism/packages/contracts/ethers-v5. Perhaps you forgot to install @typechain/ethers-v5? ``` This is...

Automatically regenerate the deployment README whenever a deployment changes

2

**Is your feature request related to a problem? Please describe.** We have [a folder named `deployments`](https://github.com/ethereum-optimism/optimism/tree/develop/packages/contracts/deployments) that holds the deployment artifacts for each of our deployments. Within this folder is...

ICrossDomainMessenger doesn't index the sender parameter of SentMessage

1

[The `ICrossDomainMessenger` interface does not index the `sender` parameter within the `SentMessage` function](https://github.com/ethereum-optimism/optimism/blob/b93353a034e82df2277efb99da4367e2b8294a36/packages/contracts/contracts/libraries/bridge/ICrossDomainMessenger.sol#L14). This means that it's quite difficult to search for events from a given sender using basic event...

CI not surfacing certain linting issues

2

**Describe the bug** I noticed that CI is not surfacing certain linting issues. For example, [this CI run had a linting warning](https://github.com/ethereum-optimism/optimism/runs/4435405432?check_suite_focus=true#step:8:546) but completed successfully. I think these sort of...

Contract sources are only copied into root before publish, breaking usage within monorepo

2

We copy our contract sources into the root of `packages/contracts` before we publish to NPM: https://github.com/ethereum-optimism/optimism/blob/e88e85d1ee2449d636a9315d25a9a2afdae5494f/packages/contracts/package.json#L41 We do this so that users can import contracts as follows: ``` import {...

Optimize the getContractAddressAtBlock function in the DTL

8

**Is your feature request related to a problem? Please describe.** We have a function called [`getContractAddressAtBlock`](https://github.com/ethereum-optimism/optimism/blob/154aab39988d7851df5e9a8fd2c0c10482ce5e5e/packages/data-transport-layer/src/services/l1-ingestion/service.ts#L411) which finds the address inside the [`Lib_AddressManager`](https://github.com/ethereum-optimism/optimism/blob/develop/packages/contracts/contracts/optimistic-ethereum/libraries/resolver/Lib_AddressManager.sol) that was associated with a given contract...

feat: Use standard RLP transactions

6

## Description Updates our sequencer entrypoint and ECDSA contracts to use the standard RLP encoding that we're using in geth now. ## Metadata ### Fixes - Fixes roadmap#754 ## Contributing...

**Description** Adds a check to prevent overflows in the safety checker. Prevents the chance that an overflow here can be used to exploit the safety checker. Currently this is *not*...

**Description** A few minor tweaks to our deploy to use the standard `registerAddress` instead of a few stragglers that were calling `Lib_AddressManager` directly.