Sébastien Maret

Results 31 comments of Sébastien Maret

Sorry for not responding earlier. I can give it a try. The first problem I ran into is authentification: [ADS requires an auth token](https://github.com/adsabs/adsabs-dev-api#access) that must be passed in the...

Thanks for your answer! I've seen the token in IEEE and Crossref, but if I understand correctly, in both cases the token as passed in the URL itself, for example:...

Result of `nixpkgs-review pr 192646` run on x86_64-darwin [1](https://github.com/Mic92/nixpkgs-review) 2 packages failed to build: python310Packages.spectral-cube python39Packages.spectral-cube 2 packages built: python310Packages.casa-formats-io python39Packages.casa-formats-io

The build failure of python310Packages.spectral-cube and python39Packages.spectral-cube are not related to this update.

For reference, here are the three figures that are created by the tests: ![test_beam_shape_from_args](https://user-images.githubusercontent.com/95471/134779630-cc0d5dae-d50f-428c-bf93-013369ac8b93.png) ![test_beam_shape_from_header](https://user-images.githubusercontent.com/95471/134779537-bcb9c305-7ade-47df-a5eb-64788182e6c3.png) ![test_scalebar](https://user-images.githubusercontent.com/95471/134779542-63c363c1-6da6-485e-a1cd-6c27ec2526fe.png)

@pllim I don't understand why the change log test is failing. I did add a change log entry (see 2f89a62).

> I am re-milestoning to v5.1 as we've now branched v5.0.x - I'm generally on board with this but I think it will require a little more work. I will...

Thanks for the comments @astrofrog. I'll look into this asap.

@astrofrog I believe that I've addressed all your comments. I've also rebased on `main` and modified the tests to use the new `@figure_test` decorator. The tests seem to run fine,...

@astrofrog I've rebased on `main`, but the `CircleCI` test still fails...