Alex Earl comments

Results 171 comments of


                                            Alex Earl

fix: JENKINS-69414 - Add OAuth 2.0 support

Is this repo participating in Hacktoberfest? If so, can this be labelled as such?

Don't swap spaces for commas.

This causes tests to fail. Is the goal here to support the format like `First Last ` as a single entity?

We can't break people. Lots of places in Jenkins spaces are used for delimiters in a list. We should just parse this correctly, maybe we can use this: https://docs.oracle.com/javaee/5/api/javax/mail/internet/InternetAddress.html#parse(java.lang.String,%20boolean)

Don't swap spaces for commas.

The help for the address fields generally say to use commas (https://github.com/jenkinsci/email-ext-plugin/blob/c5914a98487eaaf2ee93fcd0059033a3d5806742/src/main/webapp/help/projectConfig/mailType/recipientList.html for instance) , but that doesn't mean people haven't been using spaces. We would need an upgrade path...

print and exec have custom syntax error messages when using old syntax

``` >>> exec foo File "", line 1 exec foo ^ SyntaxError: Missing parentheses in call to 'exec' ```

print and exec have custom syntax error messages when using old syntax

https://github.com/python/cpython/blob/43c0f1ac5ed8bc9c3bd048d2ce4de4c98a83de99/Objects/exceptions.c#L2893

error while require "rubygems"

_From @rickmark on July 26, 2011 20:49_ You are probably debugging via visual studio. This is a normal exception that happens during the loading of ruby gems, and is handled...

Assemblies in the DLLs folder are not loaded properly

I read around that you have to use `AssemblyLoadContext.Default.LoadXXX` from `System.Runtime.Loader` have you tried that?

Tracking: Support CPython extension modules (*.pyd)

I don't think this will get life in the 2.7 releases, but we could look at it for IronPython 3

xml.dom.minidom.parse not working in ironpython 2.7

No, it was when I didn't have much time. I am planning on looking at it again.