Simon Larsén
Simon Larsén
@Chris7 Sorry for the late reply, and huge thanks for looking into the issues that I posted. Good question, and take my thoughts here with a grain of salt as...
I can note some of my findings: * Patches with only additions are problematic, as the review comments need to select at least one line to "replace". My current workaround...
FYI see https://github.com/SpoonLabs/sorald/pull/534 for where we are testing out PR review comments, and https://github.com/SpoonLabs/sorald-buildbreaker/pull/74 where we are implementing it.
The [GitHub Education pack](https://education.github.com/pack/offers) has a lot of possibly relevant free stuff. For example: * Datadog free for 2 years (monitoring) * Free Heroku hobby dyno for 2 years (hosting)...
Just for context, I'm approaching this from the perspective of applying operations from gumtree-spoon to an AST model (i.e. applying an edit script). I agree with the idea that updates...
> > I think it's confusing to not include update operations in root operations, because from an API perspective an update kind of looks like a root operation, if that...
It seems largely reasonable. What I can add is: * With this model, `UpdateOperation` should not at all be a root operation, so `getRootOperations()` should not return any update operations...
FYI this usability issue was pointed out to me by @algomaster99, I simply looked at what caused it. I'd be happy to provide a PR to compare the entire compilation...
I'm not sure it has to be all too complicated. Just comparing the packages instead of the types _kind of_ works: ```java /** * compares two java files */ public...
> > I'm not sure it has to be all too complicated. Just comparing the packages instead of the types kind of works: > > Great idea! Cool, I'll start...