Shrikrishna Singh

Results 52 comments of Shrikrishna Singh

Any updates about this?

Thanks @zerolab, Looks like this [line](https://github.com/GrappleGQL/wagtail-grapple/blob/2804dacf89525bbea6ba78b155696f9843954285/grapple/models.py#L30) could be replaced with `self.field_type = graphene.List(self.field_type)` which results in following schema: ```graphql type MainMenu { id: ID mainMenu: [StreamFieldInterface!] } ``` But in...

in [resolve_raw_value](https://github.com/GrappleGQL/wagtail-grapple/blob/2804dacf89525bbea6ba78b155696f9843954285/grapple/types/streamfield.py#L67) we are checking for StructValue but when there is nested StreamBlock the object come as StreamValue. ``` ipdb> self ipdb> self.value StructValue([('title', 'About'), ('page', ), ('sub_menu_items', [])]) ```

Thanks @zerolab, Do we want this to be handled in `GraphQLString` itself? For testing purposes I added this bit of code to the [model_resolver](https://github.com/GrappleGQL/wagtail-grapple/blob/554cb2d5d253bffd4213fbfb4fb751351ccc7a29/grapple/actions.py?_pjax=%23js-repo-pjax-container%2C%20div%5Bitemtype%3D%22http%3A%2F%2Fschema.org%2FSoftwareSourceCode%22%5D%20main%2C%20%5Bdata-pjax-container%5D#L170).. ```python cls_field = getattr(instance, field.field_source) if...

> @sks444 If you could make [atomic commits](https://www.freshconsulting.com/atomic-commits/), that'd make reviewing your PR (as well as iterating on them later) much easier! ^>^ Yes, thank you for the suggestion @pradyunsg...

I think this is ready for review now. :)

> @sks444 Why are new migrations created for conferences and proposals ? There is no change in conference or proposal model. @ananyo2012, That is coming from the `simple_history` package upgrade...

So everything seems to be running perfectly, tests are passing and I am interacting with the UI and checking if these changes break something. But as I don't have much...

Resolved the migration issue @palnabarun