Halász Dávid comments

Results 60 comments of


                                            Halász Dávid

Custom colored toolbar button icons ignore the disabled setting

@LHinson the problem here is inconsistency, if the button has no custom color (i.e. has the default one) and it becomes disabled, its color will be adjusted: ![screenshot from 2018-07-08...

Custom colored toolbar button icons ignore the disabled setting

@terezanovotna @LHinson this was a requested feature by @Loicavenel

Custom colored toolbar button icons ignore the disabled setting

@Loicavenel yes, this is the custom buttons feature with custom colors. As far as I understand @terezanovotna is suggesting to drop the coloring and have all icons gray, so we...

Custom colored toolbar button icons ignore the disabled setting

So the thing I am proposing here is to adjust the definition of the `.diabled` class on a button's icon. Right now PF [explicitly sets a color](https://github.com/patternfly/patternfly/blob/master/src/less/buttons.less#L16) with the evil...

Custom colored toolbar button icons ignore the disabled setting

@andresgalante I was looking into this, but couldn't come up with a fix, that's why I created the issue and not a PR :disappointed:

Adding images to nodes

#268 is technically the same PR against the develop branch

Fix for syntax error discarding

@mmozuras is this something you would want? Maybe this is not *The Right Way™* but the syntax errors are not always mappable to patch changes :disappointed:

Fix for syntax error discarding

I have no push rights to your repo...

[Providers] Pluggability Checklist

I got a green light from @Fryguy to move decorators, we might introduce external tests from the decorator library repo for providers using a similar approach to https://github.com/ManageIQ/manageiq/blob/master/lib/tasks/test_providers_common.rake https://github.com/ManageIQ/manageiq/blob/master/spec/models/event_stream_spec.rb

Method checkNode doesn't restore partially-checked parents.

Hi, could you please verify with the latest version and if it's still happening please provide a fiddle. Thanks