Sami Jawhar

Results 72 comments of Sami Jawhar

> Can you provide a main.tf you tested with/can be tested with/example? First, create a persistent volume with ReadWriteMany. For example: ```yaml kind: PersistentVolume apiVersion: v1 metadata: name: pv-storage labels:...

> Awesome feature, @sjawhar! heart_eyes It would be nice to enable `IndexedCompletion` automatically when `parallelism` is greater than `1` instead of exposing a separate option that has no equivalent on...

I added the `completions` functionality as described in my last comment. This just reflects what works for my use case, I'm happy to tear apart and refactor to make more...

> CompletionMode equals to NonIndexed if parallelism is 1 else Indexed I think you still might not be grokking the purpose of non/indexed. They're both valid modes of parallel operation,...

> @sjawhar, would it be possible to keep the original scope of this pull request (enable `indexed` mode when Kubernetes `completions` > 1) and open a separate pull request for...

> I thought that enabling the indexed mode doesn't have any significant effect beyond exposing a couple of additional environment variables. Which kind of unnecessary limitations do you foresee? It's...

Ok, I'll make the changes sometime in the next few days

Sorry for the long delay. I've reverted most of the changes, and implemented @0x2b3bfa0 's preferred solution.

You can see [here](https://github.com/iterative/terraform-provider-iterative/compare/master...sjawhar:terraform-provider-iterative:feature/nfs-volume#diff-0a09f57ce8a407259fdb95267183b9107b6c3bc95ddabfed2df5c678d5ccf056R179-R184) how I implemented it. Should I open a PR, or would you prefer a different implementation?

> Isn't a [StorageClass](https://kubernetes.io/docs/concepts/storage/storage-classes/#nfs) the traditional approach to solve this use case? thinking I don't _think_ so? I based my implementation on the [Kubernetes plugin for Jenkins](https://plugins.jenkins.io/kubernetes/), which generates pod...