Jason McNeil

Results 66 comments of Jason McNeil

From a dependancy CVE standpoint I think we should move forward with this PR review. Per my comments here https://github.com/jackc/pgx/issues/1352 Snyk go.mod scanning issues are false positives. Checked with govulncheck....

@ReneWerner87 this still seems to be an issue, I'll have a look this week and see if I can fix: ```bash ~/prefork Β» go run main.go sixcolors@Jason-McNeils-Mac-Pro β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β” β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β” β”‚...

Preliminary investigation: Fasthttp prefork.go `Reuseport = false` by default (except on windows, where it must be true). If `Reuseport = true` we get the same results in fasthttp example from...

I am unsure about using a file listener-based approach on macOS. I thought a lightweight load balancer that uses ports greater than 1024 might be a better option. What do...

> I was thinking, is it actually that useful to make Request and Response interfaces if Ctx is already an interface and can thus be expanded instead of Request/Response? If...

I'm also seeing issues in the Test_Ctx_Parsers tests when run from terminal with `go test ./...`: ```bash --- FAIL: Test_Ctx_Parsers (0.02s) --- FAIL: Test_Ctx_Parsers/QueryParser (0.00s) panic: runtime error: invalid memory...

Update: Discussed with @ReneWerner87 and we found issues with ctx returning nil. I've noticed an issue that appears throughout the tests. Running tests in parallel using the t.Parallel() function can...

I haven't had the chance to do a full review as I’m 🀧 and examining the PR on mobile. I'll conduct a more in-depth analysis before approving the PR. Overall...

#2854 may affect how we deal with this. @nickajacks1 please review.