sivchari

Results 53 issues of sivchari

- [ ] [improve error message](https://github.com/sivchari/gotwtr/issues/95) - [ ] [improve test coverage](https://github.com/sivchari/gotwtr/issues/105) - [ ] Replace json string to embed json.

Now, all unit tests codes mock response as string. Go provides embed feature, so we should replace all mock response to json file.

good first issue
feature request
improve

Hi, This is a small change, but it will send a PR. In the String function of expectations.go, there is a place where it initializes a variable called margs. I...

I fixed logger format.

kind/bug
ok-to-test
cncf-cla: yes
size/M

I'm interesting at the kwok and I want to contribute more. So, I want to know more about the motivation and goal of kwok. Thanks.

kind/support

### Description I fixed goroutine leaks. releted with #588 - Close Body. - Close Idle connections, if close db. ### Checklist - [x] Code compiles correctly - [x] Run ``make...

### Description Since Go1.16, `ioutil` is deprecated. So I replaced this to `os` or `io`. ### Checklist - [x] Code compiles correctly - [x] Run ``make fmt`` to fix inconsistent...

### Description I changed context.TODO to context.Background. context.Background equals context.TODO, so this change doesn't affect to any libs. But it's clear that the current implementation uses context, so we should...