Ivan Prisyazhnyy

Results 35 comments of Ivan Prisyazhnyy

> Do you understand the second test case of buffer_pool_manager_test.cpp? @iwanttbepowerful the `TEST(BufferPoolManagerTest, DISABLED_SampleTest) {` one? It that's the one, then yes. Ask what you part you don't.

The names `pin()` and `unpin()` are actually good. What really leads to the confusion is the documentation of the contracts of these APIs. It's unclear from the docs of a...

There is also a typo in a doc on `victim` method. It can't return `nullptr`: > * @param[out] frame_id id of frame that was removed, nullptr if no victim was...

nice catch. I did not check and look but I would blindly suppose it's because lxc_spawn incorrectly forks a Ruby VM. Considering invalid previous state of the timer thread meaning...

just by replacing `fork+clone3(CLONE_PARENT)` with the simple call to `rb_fork_ruby` everything suddenly starts working. however, it requires a patch to both `lxc` and `ruby-lxc`. The downside is that the parent...

does not work for proto with includes: $ grpcc -p ./api/grpc.proto -d ./api -a service:8000

> For the sake of simplicity we are assuming the write-buffer alignment to be 4096kB, and the read-buffer alignment to be 512b. Those are likely good across the majority of...

@glommer I saw that one. I just find it strange to have logical_block_size on my system to be 512. ``` $ cat /sys/block/sda/queue/physical_block_size 4096 $ cat /sys/block/sda/queue/logical_block_size 512 ``` I...

@glommer thats why I asked about having some min/max func as a workaround or at least targeting `physical_block_size` writes. Anyway, now I need to pass it to @HippoBaro as he...

We can reuse ["type"] field instead of introducing separate ["ssl"] field. Missed it while developing a variant.