Sindri Guðmundsson

Results 9 comments of Sindri Guðmundsson

Hvar er hægt að nálgast þær upplýsingar? Er hægt að setja þær fram á samanburðarhæfan hátt?

Thanks for the quick response @chdsbd. I did suspect some kind of race condition or error due to parallelism but didn't have anything to go by. When you say two...

Pretty sure this is still happening. See this one for example: https://github.com/island-is/island.is/pull/5733 https://github.com/island-is/island.is/pull/5733/commits/ecefbbfe0c4beefc92ed2c0c56bfdb2319815cdd https://github.com/island-is/island.is/pull/5733/commits/a7c236b1e701ed51d28dfb86b714dc49cfa3ea87 https://github.com/island-is/island.is/pull/5733/commits/d647687473325a4e4e37d7649ad48113c02265e5

I can create a PR for actions/toolkit to take something like `GITHUB_ACTIONS_CACHE_URL` into account when determining the cache url in https://github.com/actions/toolkit/blob/main/packages/cache/src/internal/cacheHttpClient.ts#L33. Is that what you're suggesting rather than this? I...

@bishal-pdMSFT Thanks for getting back to me. Unfortunately I no longer work for island.is but I'll try to answer your questions to the best of my knowledge. @dabbeg or @pshomov...

Looks like it should be fixed by 1cb4968956a6a7aa09e9b7808b539e4df883f610. Packaging seems to be broken though: https://github.com/aws-actions/configure-aws-credentials/actions/runs/3245630680/jobs/5323409444: ``` remote: error: GH006: Protected branch update failed for refs/heads/master. remote: error: 3 of 3...

> @sindrig any idea who should review this? @bishal-pdMSFT ? No idea. I'm not using this anymore (my old team might be) so I'm not invested in getting this in....

> So my immediate suggestion is to revert both 3.2.0 [#783](https://github.com/oauthlib/oauthlib/pull/783) and [#745](https://github.com/oauthlib/oauthlib/issues/745) to replace the code with: > > * if `expires_at` is a float, convert into a float...

Hey @AdallomRoy, will you be resolving the conflicts? I can help if needed.