Sinan Taifour comments

Results 5 comments of


                                            Sinan Taifour

Keep slack bot and auto messages consistent

I have build the code on `origin/develop`, kept the flag as true in the YAML file, but the bot is still not posting as itself.

Keep slack bot and auto messages consistent

I built after your latest commit, and it still doesn't work. Let me know if I need to provide anything for debugging. I've so far seen two messages, both weren't...

Doesn't work with diacritics

Thanks @0xAli! I'd be happy to accept a pull request for this.

404 does not pass through formatter

I would suggest instead of creating a new approach for handling 404s, to instead just raise a `Grape::Exceptions::NotFound`, and use the facilities already there to deal with exceptions. Basically, I'd...

404 does not pass through formatter

I have a structural question first: currently `build_middleware` is the one point where all middleware is put into the Rack app. Since this happens inside the endpoint, it is not...