Adam Simpkins

We will probably eventually move towards buck, but this is likely still several months away for us. We will probably wait for folly and fbthrift to provide open source BUCK...

It looks like the `--target-app-partition` code was working correctly when added in #461, but it looks like it was probably broken shortly afterwards in d886d33a69 which updated the code to...

One caveat here: I haven't tested the embassy-stm32, embassy-nrf, or embassy-rp implementations on actual hardware. That said, the unit test should hopefully provide some confidence that it works correctly. I...

> Since this is a breaking change to embassy-usb-driver which is somewhat disruptive, i'd prefer to wait until at least one in-tree driver implements the write() API (and ideally demonstrates...

This update incorporates some of the review feedback: * I renamed `write_one_packet()` to `write_packet()` * To mitigate some of the breaking changes in the embassy-usb-driver API, I left the `write()`...

> Can the method just return a count of the sent packets or bytes? No, unfortunately it can't: if the operation is dropped there is no opportunity to return anything...

Yeah, I spent a little bit of time poking around at this, and your patch looks like the correct fix to me. Note that the `CHANGED_SOURCES` computed in `_get_changes()` only...