Simon Parker

Hi @rkillick, have you had any chance to look at this? Not meaning to be pushy if you're rained in with other things at the moment!

Re some findings from the automated checks: - For `pkgcheck` note on unused imports: The function `vctrs::list_drop_empty()` is used in `openFDA()`, so needs to be imported. - The `lintr` issue...

Thanks for the comprehensive set of comments, @maelle. I've addressed many of the smaller points in commits linked in this comment, and can implement larger changes during the review process....

Hi @maelle, some commits and comments re your points: - Added return documentation for package-level options in https://github.com/simpar1471/openFDA/commit/49cc75a636165229a20acb3413a914b056a05607 - Added keyring support + unit tests in https://github.com/simpar1471/openFDA/commit/2abb2e17f714d047b8f256bc62b6ce7d28cffc70 and https://github.com/simpar1471/openFDA/commit/4d89dd1a42189a5abf535886fc4df491989d60b3 -...

> Awesome work! Do I understand correctly that you will work on the two last items before I look for reviewers? Thank you! Thank you and yes, you do! I'll...

Hi @maelle, I've rewritten the tests which can need it with vcr in commit https://github.com/simpar1471/openFDA/commit/0eeaa4e091b96c198bf96bfb477f765e550ce6f1 - this appears to be in working order, and there's a few extra commits which...