Simone Sanfratello

Results 23 comments of Simone Sanfratello

working on this - the `stale-on-error` one

I'll go with that solution, thanks! And as soon as I can I'll write a module to do that

just an update, can be done with `sinon` too

pretty sure it loads the graphql v15 from graphql-jit, instead of the actual v16 required install graphql v16 as dependency should fix it

which version of npm are you using? Not sure, but it works in different ways in v6 and v7 and v8

> @simone-sanfratello why not leave the `graphql` as a peer dependency and instruct people to install the appropriate version of GraphQL then? Specifying `graphql` as a dependency will lead to...

> @simone-sanfratello > > > because mercurius v9 specifically requires graphql v16, that's why. It doesn't work with any version of graphql, so it need a strict dependency > >...

![mercurius](https://user-images.githubusercontent.com/5823031/151985589-5785d7ee-27df-427b-8243-3228f7ce1634.png) this is the situation as is, with `graphql` as explicit dependency of `mercurius`, for an application installed as ``` npm i fastify mercurius ``` that's why we need this,...

I'm not a maintainer of this module, but I guess your PR is not going to be merged because it doesn't pass tests. You were right if `graphql` were installed...