Simon Engledew

Results 12 comments of Simon Engledew

> Each item in this page should mention length and other constraints as well... The limits on the three fields in that table are: * Name - 255 characters *...

👋 Sorry to take so long to get back to you. 🙇 😞 We use the help.text field as a fallback if the markdown field is not provided. We treat...

Thanks for the explanation! That totally tracks with what I am seeing. 👍 For context I work at GitHub, hi! 👋 😅 – we have various internal limits to stop...

> So, if you're discarding rules, I guess users may not see the bottom block (tool/rule-id and description) from the screenshot below if we report many issues? Funnily enough that's...

> I guess this means that you're storing rules across repositories rather than per-repository? Yeah, it's a lot of data so we have to deduplicate the storage of rule text....

> Does GitHub potentially store multiple descriptions for the same rule id (showing the description that matches the contents of the SARIF file for a particular repository), or will it...

> Will GitHub properly render any links in `results[].message.text` I think you might need to use `results[].message.markdown`, but yeah! If you include a markdown link then it will be clickable:...

I think the SARIF spec is right so it's quite likely I've either a) made a mistake or b) we support it as a happy accident. 😅 Looking through a...

Sure! I've modified a CodeQL SARIF file and added a link into `results[].message.text`. ```json { "$schema" : "https://raw.githubusercontent.com/oasis-tcs/sarif-spec/master/Schemata/sarif-schema-2.1.0.json", "version" : "2.1.0", "runs" : [ { "tool" : { "driver" :...

Sorry for taking so long to get back to you! 🙇 😓 > can you please review the SARIF files in [this repository](https://github.com/rsenden/sarif-test/) (and associated GitHub Code Scanning alerts if...