Andrew Simms

Specific issue is here: https://github.com/MHKiT-Software/MHKiT-MATLAB/blob/e780f1c13680d74d22c68be092634c3da5d1e527/mhkit/wave/IO/hindcast/request_wpto.m#L117-L118 Anticipated fix is to remove dashes from parameter(z): ```{matlab} sanitized_parameter = strrep(parameter(z), '-', "_"); data(y).(sanitized_parameter) = param.value; ```

* Read NetCDF all data attributes, not just "units". * Fix a bug in nan_beyond_surface where the depth mask was not being created properly * WIP: Add tests for cleaning...

NOAA Data Removal

1

Related to https://github.com/MHKiT-Software/MHKiT-Python/issues/394 Need to verify that NOAA download functionality in MHKiT-MATLAB is not affected by decommissioning of some NOAA API endpoints:

This pr adds the `mhkit.install()` command which handles MHKiT-Python installation for MATLAB users.

Power Module: Convert to native MATLAB code

1

This PR removes the python calls to MHKiT-Python and rewrites the MHKiT-Python functionality in native MATLAB code: * [x] `mhkit/power/characteristics/ac_three_phase.m` * [x] `mhkit/power/characteristics/dc_power.m` * [x] `mhkit/power/characteristics/instantaneous_frequency.m` * [x] `mhkit/power/quality/calc_electrical_angle.m` (Already...

Feature: Fix and add test for incorrectly formatted docstrings

1

Status: Ready for Review Add docstring validation python script and fix current issues with docstrings prevent sphinx from building the documentation: The `scripts/check_docstrings.py` python script validates MATLAB function docstrings against...

Current Status: Work in Progress * Add ADCP/ADV test files from latest MHKiT-Python * Split reader tests into multiple files * Add comparison function to tests to check for any...

Actions: Need to test against the latest versions of MATLAB

1

The current Actions/tests go up to MATLAB 2024b. We need to update to 2025a, and possibly newly released 2025b. https://www.mathworks.com/support/requirements/python-compatibility.html R2025a supports python 3.9 to 3.12 R2025b supports python 3.10...

https://mhkit-software.github.io/MHKiT/ADCP_Delft3D_TRTS_example.html Source Code: https://github.com/MHKiT-Software/MHKiT-Python/blob/main/examples/ADCP_Delft3D_TRTS_example.ipynb A likely blocker here is support for reading `PD0` files: ```{python} # Read in the two transect passes transect_1_raw = api.read( "data/river/ADCP_transect/tanana_transects_08_10_10_0_002_10-08-10_142214.PD0" ) transect_2_raw = api.read(...

Reading an original binary ADCP file is slow in MHKiT-MATLAB. In examples/adcp_example.m: ``` ds = dolfyn_read('data/dolfyn/Sig1000_tidal.ad2cp'); ``` Yields: ``` Reading binary data... Reading file data/dolfyn/Sig1000_tidal.ad2cp Binary read time: 62.498 seconds...