Simarjeet Singh comments

Results 9 comments of


                                            Simarjeet Singh

Add unit tests to System.Windows.Forms.Design.* components

Hey @JuditRose, can I look into this? Is this still active?

[Improvement] Possible null pointer exception in CatalogRegister.java

Hello @justinmclean , can I have a look on this? I think I can resolve this.

[Improvement] Possible null pointer exception in CatalogRegister.java

I am thinking of removing the **failedException** variable, moving exception handling inside the retry loop, and directly throwing a **TrinoException** when retries are exhausted. I also thought of adding proper...

[Improvement] Possible null pointer exception in CatalogRegister.java

I made some changes to fix the NPE and improve the method. Please have a look :- #4201

[Improvement] Possible null pointer exception in CatalogRegister.java

can u elaborate on this please

[Improvement] Possible null pointer exception in CatalogRegister.java

Yes, I'll continue working on this right now. I've been busy with other important work lately. Sorry for the inconvenience

rag_with_eval.py has a lots old content and cannot run correctly

Hi @StoneWillow , can I work on this?

rag_with_eval.py has a lots old content and cannot run correctly

> > Hi [@StoneWillow](https://github.com/StoneWillow) , can I work on this? > > Sure, what do you need Thanks! I will setup this project locally and try to fix this issue....

[Improvement] In Distribution.java correct equals method

Hello @justinmclean, can you please provide more details about this issue?