Simon Nyberg comments

Results 21 comments of


                                            Simon Nyberg

Event loop lag should be a summary, not a gauge

Yeah, histogram is the way to go

Support Bigint

Yeah, we need to support all current official node versions.

Added opportunity add any registry to merge with clusters

@zbjornson do you have any opinions?

Added opportunity add any registry to merge with clusters

Still waiting for a test before merging this one

[Feature] ExponentialBuckets with start and end

I think your suggestion is good, to have an object as first parameter. But if you implement it that way, please keep the backwards compatibility so we don't need to...

Relax necessity of declaring labelset in advance

Sorry for being late on the ball here, thanks for your suggestion and input. Me personally would love to drop this too since it just adds complexity. My main concern...

Suggested pattern for metrics in libraries

In my opinion, I would let the library have it's own requirement to `prom-client` and then create all their metrics in a custom registry. Then in the main application, I...

Counter reset that sets every value to zero

Ugh I dont really like the reset function overall and not sure on adding more functionality to it. Making the Api more complex for the reset function makes people think...

Labels values containing a " are not escaped, leading to "no token found" scraping error

It depends I would say.. if we could escape/sanitize it without affecting the performance too much I think we should handle it.

Merging of registers ignores default labels

Imo the default metrics should only be applied to the metrics that came from the registry with default metrics after a merge. Otherwise other registries could affect others and that...