siimav

Limit texture size used for maps

4

Happened twice already. Here's the crash logs for both of them: [error.log](https://github.com/S-C-A-N/SCANsat/files/5009259/error.log) [error.log](https://github.com/S-C-A-N/SCANsat/files/5009271/error.log)

Cost calculation run even during flight

1

This can cause a significant performance impact when the user has tons of mods. Calls to Part.GetModuleCosts means that KSP iterates over all the PartModules that the part has to...

Suggestion: Add `$format` media type mappings

1

https://github.com/xuzhg/MyAspNetCore/blob/f08a774c4bbe160f6359ad5241b713c70112789c/src/ODataCustomizePayloadFormat/ODataCustomizePayloadFormat/Program.cs#L18-L24 In addition to adding `SupportedMediaTypes`, I would also suggest adding `MediaTypeMappings`, for example: `odataFormatter.MediaTypeMappings.Add(new QueryStringMediaTypeMapping("$format", "csv", "text/csv"));` Took me a while to figure out why appending `?$format=text/csv` to URL...

A few Scatterer errors in debug mode

2

Found a few errors and exceptions related to Scatterer when loading KSP 1.10.1 in debug mode. This is from my full RSS/RO/RP-1 install. [Scattererdebug.txt](https://github.com/LGhassen/Scatterer/files/5308672/Scattererdebug.txt)

TS upgrades do not apply if completed in flight scene

1

The use case is RP-1 simulations that happen in far future where a facility upgrade will get completed. RP-1 will call `UpgradeableFacility.SetLevel()` which in turn will fire the following events:...

On most frames the performance impact is insignificant but sometimes it spikes to 15ms. Profiler output from launching a rocket that contains 4 rover wheels: 

The two FAR VesselModules should only be active on loaded vessels. In particular `FlightGUI.FixedUpdate()` was rather expensive with many vessels in flight. In my test save this reduced per frame...

Implement faster lookup of PartModules

3

This means adding a dependency for KSPCF though. I tried to preserve the original behavior of code wherever possible but some `PartModule is null` checks got removed. However I don't...

Also extracted these mod installed checks into a separate class.

Without this there is no way to ensure that KSP will load TU assembly before any mod that references it.