Dávid Szigecsán comments

Results 8 comments of


                                            Dávid Szigecsán

Remove unnecessary boxing / unboxing

@hzbarcea After a while, I resolved the conflict. :)

Remove unnecessary boxing / unboxing

@jbonofre Maybe you are a bit more active and could check this PR.

Passing classpath in file by default

> Not yet. I'll fix them on the weekend. :)

Passing classpath in file by default

@szpak I've fixed the broken test cases by setting the `useClasspathFile` as false in the tests (as it was before). And there is one test case when it is true....

Drop coveralls code-coverage flow?

Hi, For checking and requiring a minimum test coverage you could use jacoco as it is used in [apache commons project](https://github.com/apache/commons-parent/blob/master/pom.xml#L218). There is no generated badge for readme, but the...

Replace the specified string with the one enclosed between two other strings(‘open’ and a ‘close’).

@Yash-777, @555vedant -1 In my opinion, replaceSubstringInBetween() is not needed. If you really need such replacements, RegExUtils.replacePattern() can do the same with proper parameters. I think.

Jacoco Coverage doesn't meet specified criteria if run in release mode

> The reason for it is, that if docker is not available (and tests are skipped), the coverage criteria is not meet and the build is failing. This should be...

[Improvement] The Metadata should handle all the case sensitivities

Well, I'm not 100% sure what would be the best solution here, but I would use [equalsIgnoreCase](https://docs.oracle.com/javase/8/docs/api/java/lang/String.html#equalsIgnoreCase-java.lang.String-) for checking if something is present or not. My thoughts are to let...